-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change setup wizard icon to choose add-ons to install #2073
Conversation
remove shopping cart icon Signed-off-by: Andrew Rowe <exectechnology@gmail.com>
Can you please explain why you want to remove that icon? |
Yes, of course sorry.... https://community.openhab.org/t/first-time-user-wizard-for-oh4/149670/4?u=andrew_rowe |
my 2 cents: I wouldn't want to drop the icon completely as it has some nice appearance. I would ask you to come up with a better icon instead. |
Why not use the basket like in the side menu ? |
So why not update your PR and remove icon deletion in favour of replacing it with the shopping basket ? |
I agree that the shopping cart is not the best icon, it also reminds me of paying money for something. When searching for a better icon, keep in mind that we both need a Material icon (https://jossef.github.io/material-design-icons-iconfont/) and a Framework 7 icon (https://framework7.io/icons/).
They do not go to the same thing: The first link opens up https://www.openhab.org/addons/, where you can have a closer look at the add-ons, the second link opens a simple selection which add-ons to install. |
Personally I support the idea of removing the shopping cart. In any real-world or internet scenario this is commonly used to shop goods that are to be payed in some sort of a checkout process - which is not the case here. And as we are talking about making things more understandable to Newbies: Yes, i know, there are ones for scripting, purely technical stuff etc. This is what we should try to achieve: Keep it simple and support initial quick wins for new users. Does that make sense to you? |
Just to try to clarify, when I made that screen and used that icon, the intent was that you would be "shopping" for add-ons that you would install as part of the setup process. I used We can also wonder about this step, it's certainly convenient for users who are used to spinning up openHAB instances, but for real first-time users, it's an inferior experience than the add-on store. |
use bag_fill_badge_plus icon instead of shopping cart Signed-off-by: Andrew Rowe <exectechnology@gmail.com>
I added the bag_fill_badge_plus icon instead of the shopping cart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this change, thanks for the discussion.
Signed-off-by: Andrew Rowe <exectechnology@gmail.com> Signed-off-by: jgeorgi <justin.georgi@gmail.com>
Signed-off-by: Andrew Rowe <exectechnology@gmail.com> Signed-off-by: jgeorgi <justin.georgi@gmail.com>
Signed-off-by: Andrew Rowe <exectechnology@gmail.com>
remove shopping cart icon from add-ons wizard
I am user Andrew_Rowe on the openHAB community forum